Repository navigation
refactor(queue): restore koru.queue lower-layer import contract (ticket-474) - #736
Merged
ifuri-validator-agent[bot] merged 1 commit intoOct 19, 2026
Conversation
…et-474, Closes #731) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![ifuri-validator-agent[bot]](https://avatars.githubusercontent.com/in/4344831?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Validator approval after policy checks for exact head 331233920c99db92be082ea962f061d571749177.
Ticket: ticket-474
Correlation ID: koru474-after-scratch-recovery-20261020
Model: openai/cursor-auto
Reviewed diff chunks: 3
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 3 diff chunk(s). The visible chunk cleanly redirects lower-layer imports to neutral modules while preserving existing autonomy import paths through re-exports. No unresolved code or security defect is evident in this chunk, and all protected required checks passed. | The visible chunk cleanly relocates ticket-log and drive-budget helpers into neutral modules, updates lower-layer imports, and preserves compatibility through re-exports. The required protected checks passed, and no unresolved code or security defect is evident in this chunk. | The visible chunk adds focused import-boundary, compatibility re-export, and drive-budget limit tests. Protected required checks passed, and no code or security defects are evident in this chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 542339cd8dfcae760a03de346db4616a0eba9f42...331233920c99db92be082ea962f061d571749177
Change digest: cfec6a9489396af2adec46fd037db276ee2f4aa62533bb5c4da467cbcf0544f3
Score: 64/100 (L), estimated 96 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":410,"base_sha":"542339cd8dfcae760a03de346db4616a0eba9f42","binary_files":0,"categories":{"code":7,"configuration":1,"docs":1,"tests":1},"change_digest":"cfec6a9489396af2adec46fd037db276ee2f4aa62533bb5c4da467cbcf0544f3","comparison":"542339cd8dfcae760a03de346db4616a0eba9f42...331233920c99db92be082ea962f061d571749177","deletions":200,"file_count":10,"files":["project/ticket-474/README.md","project/ticket-474/intent.json","src/koru/activity_log.py","src/koru/autonomy/cycle_trace.py","src/koru/autonomy/verification_engine/budget.py","src/koru/bounded_contexts/planfile_queue/application.py","src/koru/drive_budget.py","src/koru/task_model_policy.py","src/koru/ticket_logs.py","tests/test_queue_layer_contract.py"],"head_sha":"331233920c99db92be082ea962f061d571749177","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":2,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":96,"within_budget":false},"impact":{"components":["claude.com","origin","packages/koruide","project","src/koru","tests"],"files":["claude.com/claude-code","origin/main","packages/koruide/src","project/governance-check.sh","project/ticket-474/README.md","project/ticket-474/intent.json","src/koru/activity_log.py","src/koru/autonomy/cycle_trace.py","src/koru/autonomy/verification_engine/budget.py","src/koru/bounded_contexts/planfile_queue/application.py","src/koru/drive_budget.py","src/koru/task_model_policy.py","src/koru/ticket_logs.py","tests/test_queue_layer_contract.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":64,"split":{"parts":[{"estimated_minutes":15,"name":"Implement claude.com","scope":["claude.com"]},{"estimated_minutes":15,"name":"Implement origin","scope":["origin"]},{"estimated_minutes":15,"name":"Implement packages/koruide","scope":["packages/koruide"]},{"estimated_minutes":15,"name":"Implement project","scope":["project"]},{"estimated_minutes":15,"name":"Implement src/koru","scope":["src/koru"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-474"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-474: refactor(queue): restore koru.queue lower-layer import contract (ticket-474)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 96m</text></svg>DECISION D-474-4496
TICKET ticket-474
HEAD_SHA 331233920c99db92be082ea962f061d571749177
CORRELATION_ID koru474-after-scratch-recovery-20261020
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["standard packs / conformance=PASS","governance / remote lifecycle=PASS","governance / enforce=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/koru","pull_request":736,"head_sha":"331233920c99db92be082ea962f061d571749177","base_sha":"04a5b3e9ba882a55330ac3acb5f3e9a4979fe1ab","diff_sha256":"03876e741fb6c2da8a647b976e943b68baa5edb62c62fc5fcb61a6fdb52d81b1"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-474/README.md","project/ticket-474/intent.json","src/koru/activity_log.py","src/koru/autonomy/cycle_trace.py","src/koru/autonomy/verification_engine/budget.py","src/koru/bounded_contexts/planfile_queue/application.py","src/koru/drive_budget.py","src/koru/task_model_policy.py","src/koru/ticket_logs.py","tests/test_queue_layer_contract.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"542339cd8dfcae760a03de346db4616a0eba9f42","head_sha":"331233920c99db92be082ea962f061d571749177","change_digest":"cfec6a9489396af2adec46fd037db276ee2f4aa62533bb5c4da467cbcf0544f3","score":64,"complexity":"L","estimated_minutes":96,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
ifuri-validator-agent
Bot
deleted the
ticket/474-restore-koru-queue-lower-layer-import-contract-731
branch
October 19, 2026 23:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #731.
ci.ymlon main had failed for 200+ consecutive runs at Import contracts, so Pytest never ran on main. The contractkoru.queue is a lower layer: no autonomy or daemon importswas broken through three chains:The helpers those lower layers need are stdlib-only, so they move to neutral modules:
koru.ticket_logs:find_ticket_dir,append_ticket_markdown_log,append_queue_ticket_markdown_log;koru.drive_budget: the per-ticket drive budget.koru.autonomy.cycle_traceandkoru.autonomy.verification_engine.budgetre-export them, so every existing import keeps working. The three lower-layer callers import the neutral modules. No behaviour change.Verification
lint-imports(PYTHONPATH=src:packages/koruide/src): 3 kept, 0 broken (before: 2 kept, 1 broken).tests/test_queue_layer_contract.py: an AST guard that the lower-layer callers don't importkoru.autonomy; identity checks for the re-exports; drive-budget behaviour.-n 8): 15 failed, 5 errors — the same as on main (1039 passed vs 1036). The one name that differed (test_skip_due_to_recent_chat_activity_heuristic_can_be_disabled) is timing-flaky and passes and fails on both main and this branch when run serially.ruff check: clean../project/governance-check.sh --base origin/main→ GOV-PASS.Follow-up worth considering: once main is green, make
ci.yml / testa required check.🤖 Generated with Claude Code